Repository navigation
Add feature to disable component - #103
Conversation
There was a problem hiding this comment.
Please filter out undefined records inside the compiler.
A possible implementation, sorry for giving you a wrong one initially:
return Object.keys(...)
.filter(..check config is truthy..)
.map(..original map function..)
|
One comment, the rest looks good. |
011d5ec to
3ed3e88
Compare
|
Made following changes
@bajtos , can you please review? |
There was a problem hiding this comment.
Are you using tab characters here? Please ensure you use only spaces for indentation (you may need to change the settings in your editor).
There was a problem hiding this comment.
I've used space character here for indentation. I also cross-verified the editor settings. And it is set to use "spaces" only for indentation. Although not sure, why does it highlight here in green!
There was a problem hiding this comment.
Perhaps it's GitHub's way of showing that the line differs in whitespace only. Don't worry about that then.
3ed3e88 to
d75a034
Compare
|
Modified the test case to use @bajtos - can you please review? |
There was a problem hiding this comment.
Style: it's best to keep the chain of chai assertions on a single line. Also when a statement continues on a next line, the next lines should be indented by two spaces.
// either
expect(Object.keys(require.cache))
.to.include(appdir.resolve('components/test-component/index.js'));
// or
expect(Object.keys(require.cache)).to.include(
appdir.resolve('components/test-component/index.js'));The same comment applies to the test below.
|
Also please sign the CLA for this project here: https://cla.strongloop.com/agreements/strongloop/loopback-boot (the page is linked from "Details" in the list of failing checks too). |
d75a034 to
2c4b6f0
Compare
|
@bajtos, |
|
@slnode test please |
Add feature to disable component
|
Landed, thank you. |
In reference to strongloop/loopback-component-explorer#51, added implementation to disable components through
component-config.json@bajtos, please review.